-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectivity: Ignore expected XFRM errors #2190
Conversation
5635661
to
229ffd6
Compare
229ffd6
to
f33d5c8
Compare
f33d5c8
to
257c4f2
Compare
257c4f2
to
6974211
Compare
This commit refactors computeExpectedDropReasons to move the core logic to the utils package. We will need to reuse that logic for another set of exceptions, this time for XFRM errors. There are no functional changes in this commit. Signed-off-by: Paul Chaignon <[email protected]>
We have a couple XFRM errors, XfrmInError and XfrmFwdHdrError, that can be expected to slightly increase in specific scenarios. Those have started occuring in CI so we need a way to ignore them. This commit implements that, as well as a connectivity test flag to control the list of XFRM errors to ignore. This is similar to what I did for drop reasons in commit 4880c91 ("connectivity: Check for unexpected packet drops") and b5e40ba ("connectivity: Add flag --expected-drop-reasons"). In addition, because those errors are only expected to happen in very small amount, we only ignore them if there are less than 10 such errors. It is critical that we fail tests if these errors become more frequent. Signed-off-by: Paul Chaignon <[email protected]>
6974211
to
7e3a3e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If len(inputExceptions) == 0
, ComputeFailureExceptions
returns an empty slice regardless of defaultExceptions
. But the original logic appears to be same, there should be not a problem.
Yeah, that bugged me a bit as well. The flag takes I believe that should match the intended behavior from users of the flag. |
First commit refactors the existing logic for the
--expected-drop-reasons
. The second adds a new--expected-xfrm-errors
.